feat: Add is_weekday() and is_weekend() methods to Arrow#1274
Open
walle250ai wants to merge 1 commit intoarrow-py:masterfrom
Open
feat: Add is_weekday() and is_weekend() methods to Arrow#1274walle250ai wants to merge 1 commit intoarrow-py:masterfrom
walle250ai wants to merge 1 commit intoarrow-py:masterfrom
Conversation
Adds two convenience predicates to the Arrow class: - is_weekday() → True if Mon–Fri (weekday() in range(0, 5)) - is_weekend() → True if Sat–Sun (weekday() in (5, 6)) Both methods are placed after isoweekday() and follow the same docstring style. Tests added to TestArrowDatetimeInterface.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1274 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2319 +4
Branches 358 358
=========================================
+ Hits 2315 2319 +4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two convenience predicates to the Arrow class:
Both methods are placed after isoweekday() and follow the same docstring style. Tests added to TestArrowDatetimeInterface.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes